ARTEMIS-4601 remove OpenTelemetry deps from main pom #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-4601
branch
from
1e3fc08
to
10486fe
Compare
|
io.opentelemetry:opentelemetry-semconv 1.34.1-alpha doesn't exist, the latest version is 1.30.1-alpha it was moved to io.opentelemetry.semconv:opentelemetry-semconv the latest version of io.opentelemetry.semconv:opentelemetry-semconv is 1.23.1-alpha |
|
Looking at this a bit more closely...I think we can remove the OpenTelemetry dependencies from the main |
jbertram
force-pushed
the
ARTEMIS-4601
branch
from
10486fe
to
2cec6bd
Compare
jbertram
changed the title
|
It makes even more sense now that the examples are separated from the main repo. |
The OpenTelemetry dependencies can be isolated to the `opentelemetry` example in the `activemq-artemis-examples` repo. They aren't needed here anymore.
jbertram
force-pushed
the
ARTEMIS-4601
branch
from
2cec6bd
to
443dc11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.