Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-4617 upgrade JLine to 3.24.1 #4790

Closed
wants to merge 1 commit into from

Conversation

jbertram
Copy link
Contributor

No description provided.

@clebertsuconic
Copy link
Contributor

when you run the the CLI after upgrading here, you get this:

clebertsuconic@MacBook-Pro bin % ./artemis
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jline.terminal.impl.exec.ExecTerminalProvider$ReflectionRedirectPipeCreator (file:/Users/clebertsuconic/work/apache/activemq-artemis/artemis-distribution/target/apache-artemis-2.33.0-SNAPSHOT-bin/apache-artemis-2.33.0-SNAPSHOT/lib/jline-3.24.1.jar) to constructor java.lang.ProcessBuilder$RedirectPipeImpl()
WARNING: Please consider reporting this to the maintainers of org.jline.terminal.impl.exec.ExecTerminalProvider$ReflectionRedirectPipeCreator
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
     _        _               _

@clebertsuconic clebertsuconic marked this pull request as draft January 31, 2024 18:18
@clebertsuconic
Copy link
Contributor

I would leave this one out TBH

@jbertram jbertram changed the title ARTEMIS-4617 upgrade JLine to 3.25.1 ARTEMIS-4617 upgrade JLine to 3.24.1 Jan 31, 2024
@clebertsuconic
Copy link
Contributor

@jbertram I opened jline/jline3#937

@gnodet
Copy link
Contributor

gnodet commented Feb 1, 2024

when you run the the CLI after upgrading here, you get this:

clebertsuconic@MacBook-Pro bin % ./artemis
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jline.terminal.impl.exec.ExecTerminalProvider$ReflectionRedirectPipeCreator (file:/Users/clebertsuconic/work/apache/activemq-artemis/artemis-distribution/target/apache-artemis-2.33.0-SNAPSHOT-bin/apache-artemis-2.33.0-SNAPSHOT/lib/jline-3.24.1.jar) to constructor java.lang.ProcessBuilder$RedirectPipeImpl()
WARNING: Please consider reporting this to the maintainers of org.jline.terminal.impl.exec.ExecTerminalProvider$ReflectionRedirectPipeCreator
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
     _        _               _

To get rid of this warning, it should be possible to define the system property org.jline.terminal.exec.redirectPipeCreationMode and give it the value native. This should use a native method instead of reflection and should avoid this warning.

This is not the latest version, but 3.25.x requires Java 21+ at
build-time.
@jbertram
Copy link
Contributor Author

jbertram commented Feb 1, 2024

@clebertsuconic, after all the other upgrades I rebased and when I build and test locally I don't see those warnings. This is what I see:

$ ./artemis 
     _        _               _
    / \  ____| |_  ___ __  __(_) _____
   / _ \|  _ \ __|/ _ \  \/  | |/  __/
  / ___ \ | \/ |_/  __/ |\/| | |\___ \
 /_/   \_\|   \__\____|_|  |_|_|/___ /
 Apache ActiveMQ Artemis 2.33.0-SNAPSHOT


For a list of commands, type help or press <TAB>:
Type exit or press <CTRL-D> to leave the session:
Apache ActiveMQ Artemis 2.33.0-SNAPSHOT >

@clebertsuconic
Copy link
Contributor

@jbertram I'm handling the dependency between maven and jline to allow upgrading to latest.

@clebertsuconic
Copy link
Contributor

@jbertram this is superseded by #4800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants