ARTEMIS-4637 - Allow unordered xml conf elements for clusters and bri… #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this LGTM. Thanks a lot for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dges
I hope this change makes sense as it's a little bit outside of my comfort zone... it's purpose is to fix a minor annoyance of mine and something Ive seen confuse some other users as well, where moving or adding a configuration element in the wrong place causes the config to be invalidated.
A side effect of this change is that the cluster property/attribute
allow-direct-connections-onlyinstatic-connectorswould pass validation even on core-bridges... setting this property has no effect on the core-bridges either way so I'm hoping it's not a cause for concern. I made it that way to have current configurations validate as before this change instead if adding it as a separate element within the cluster config or similar. Ideas on how to make this better if it's an issue are welcome.Ideally this would apply to all configuration at some point but I believe that would require moving to xsd version 1.1 which is not scoped in this change.