ARTEMIS-4641 Support events for add of missing federation resources #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run the full test suite with these changes. |
gemmellr
reviewed
Feb 12, 2024
...org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationEventSupport.java
Outdated
Show resolved
Hide resolved
...org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationEventSupport.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationSource.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationSource.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationSource.java
Outdated
Show resolved
Hide resolved
When an AMQP federation instance attempts to federate an address or queue it can fail if the remote address or queue is not present or cannot be created based on broker policy. A federation link can also closed if the federated resource is removed from the remote broker by management etc. In those cases the remote broker should note the resources that were targets of federation and send alerts to the source federation broker to notify it that these resources become available for federation and the source should attempt again to create federation links if demand still exists. This allows an AMQP federation instance to heal itself based on updates from the remote.
tabish121
force-pushed
the
amqp-federation-events
branch
from
a478d44
to
b759dcf
Compare
|
Made the cleanups requested and rebased. Ran all AMQP federation tests again and all passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AMQP federation instance attempts to federate an address or queue it can fail if the remote address or queue is not present or cannot be created based on broker policy. A federation link can also closed if the federated resource is removed from the remote broker by management etc. In those cases the remote broker should note the resources that were targets of federation and send alerts to the source federation broker to notify it that these resources become available for federation and the source should attempt again to create federation links if demand still exists. This allows an AMQP federation instance to heal itself based on updates from the remote.