ARTEMIS-4648 support typed properties from CLI producer #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-4648
branch
from
779283a
to
c42fdce
Compare
artemis-cli/src/test/java/org/apache/activemq/cli/test/CliProducerTest.java
Outdated
Show resolved
Hide resolved
artemis-cli/src/test/java/org/apache/activemq/cli/test/CliProducerTest.java
Outdated
Show resolved
Hide resolved
gemmellr
reviewed
Feb 27, 2024
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ProducerThread.java
Outdated
Show resolved
Hide resolved
|
Related question. Does adding the ability to send properties with the CLI producer, perhaps also suggest there would be utility in having the option for the CLI consumer to print such properties? E.g either print all, or specifically specified ones. |
jbertram
force-pushed
the
ARTEMIS-4648
branch
from
c42fdce
to
83dff1b
Compare
|
@gemmellr, yes, I do think that's a worthy improvement for the consumer. I opened ARTEMIS-4659 for this. |
gemmellr
reviewed
Feb 29, 2024
artemis-cli/src/test/java/org/apache/activemq/cli/test/CliProducerTest.java
Outdated
Show resolved
Hide resolved
jbertram
force-pushed
the
ARTEMIS-4648
branch
5 times, most recently
from
6899a61
to
c95f62d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.