ARTEMIS-4723 Avoid objects left on ThreadLocal from OrderedExecutorFactory #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebertsuconic
commented
Apr 11, 2024
| // We don't have an option where we could do an immediate timeout | ||
| // I just need to make one roundtrip to make sure there's no pending tasks on the loop | ||
| // for that I ellected one second | ||
| flush(timeout, unit); |
There was a problem hiding this comment.
This was for tests and it was still causing issues anyway...
so, time to go !!! more issues than benefits
|
@cardamon notice I'm keeping you as the author on the commit. as you discovered the issue. I went further and just removed the usage. if all my tests are good I will merge this. |
clebertsuconic
force-pushed
the
fix-leak
branch
7 times, most recently
from
4db3759
to
04ce261
Compare
Thanks! |
|
even thought I wanted to get rid of the shutdown.. that represented some semantic change.. and it's impossible to measure consequences. I will have to keep the behaviour to avoid breaking use cases and causing unexpected issues. |
clebertsuconic
force-pushed
the
fix-leak
branch
4 times, most recently
from
8fe1dee
to
f72f5b5
Compare
…ctory co-authored: Jakob van Kruijssen <cardamon@gmail.com>
clebertsuconic
force-pushed
the
fix-leak
branch
from
f72f5b5
to
6423786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-authored: Clebert Suconic