ARTEMIS-4774 Fixing PageCounters out of sync after AckMnager retries #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the sync should be called outside of the lock. if the file was already closed it should then just be ignored as the data was locked anyway.
clebertsuconic
force-pushed
the
page-counters-PR
branch
9 times, most recently
from
f5d1402
to
158d7aa
Compare
clebertsuconic
force-pushed
the
page-counters-PR
branch
from
158d7aa
to
656e1b5
Compare
|
I need to merge this PR. I have hours and hours of testing on this where I tweaked parameters.sh in multiple ways and the counters are always accurate. If there are minor issues or even tweaks that are needed to the code those could be addressed in a later PR.. .or feel free to send further commits on the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.