ARTEMIS-670 Adding destination creation and deletion cli command

[gaohoward]

No description provided.

[gaohoward]

seems the failures are unrelated to this commit. Looking into it now.

[gaohoward]

They all pass on my local env so those are not related to the commit.

[clebertsuconic]

I think this gets a bit confused for users...

Why don't you add the following commands:

create-queue
create-topic
delete-queue
delete-topic

You can have abstract classes for what is common among the classes. It will be the same implementation almost, but the user would have more control on what he wants to be done.

The way this is structure, you are using a create-queue command to delete it. I don't think it's too intuitive to the user.

[gaohoward]

ok, sounds good. I'll do it. Thanks Clebert.

[clebertsuconic]

@howardgao one thing you could do.. is to use sub-commands... look at data...

you have data print, data exp... etc

you could have queue create, queue add, ... etc...

even do ./artemis help queue to list the sub commands

[gaohoward]

I think using sub commands is not better than single commands as you previously suggested.

[clebertsuconic]

@gaohoward It is the same thing... just an organizational thingy.

do separate commands for now. I can do it as a little tweak later.

[gaohoward]

@clebertsuconic ok done.

[clebertsuconic]

@gaohoward when I wrote the delete-topic up here was just as an example of separating the commands. I didn't mean to be literal. Do you actually need to differenticate delete-topic from delete-queue or it could just be delete?

[johnament]

I personally prefer (create|delete)-(topic|queue). This doesn't mean the others shouldn't be there, but they can be aliased. This way either could work.

[gaohoward]

@clebertsuconic yeah we can combine the delete-topic and delete-queue, but having them in separate commands is not bad. I really don't have any preferences of one over the other.

[clebertsuconic]

@johnament I liked the idea... we can't use create though on the CLI as it's used to create a broker..

although we could use it with a group:

./artemis dest create --queue ...etc etc
./artemis dest delete --queue | topic

[jbertram]

One concern I have is that I can't tell by the names if these commands are operating on JMS resources or core resources. Obviously there's no such thing as a core topic so I assume that the topic-related commands are operating on a JMS topic. However, core has a queue and JMS has a queue. If the commands are dealing with JMS resources then I think the might need to reflect that to avoid confusion.

[clebertsuconic]

@jbertram maybe we could call the group jms
artemis jms create --queue(default) | --topic --name name
artemis jms delete --name name (I'm not convinced we need --queue or --topic here?, we could figure out from the search?)

then we could have

artemis core create
artemis core delete

?

[gaohoward]

@jbertram by default create-queue creates jms queues, if you want create a core queue, use --core option, like

artemis create-queue --core --name corequeue1 (optionally you can also give a --address option)

delete-queue has --core option too

[gaohoward]

@clebertsuconic that kinda goes back to my original impl, which combine all the functionalities into one command, i.e.

./artemis destination create|delete --name myqueue1 --core

which is not so good in that some options are irrelevant for certain operations, causing confusion. for example delete a queue is just need a name, the filter, jndi bindings, etc are not relevant. If people do

./artemis help destination

it will print all the options together. Having separated commands can reduce the confusion, because each command has only relevant options.

[clebertsuconic]

@gaohoward It's different.. you had the behaviour specified by properties... which was the confusing part.

Grouping is different... you still have separated commands, and aggregate them on the help. just like data.

[gaohoward]

@clebertsuconic ok looks like the sub-command style (like data command) has no objection. I'll go for it. Thanks

[gaohoward]

@clebertsuconic I've update my commit. pls review. Now if you run help it will print look like this:
]$ ./artemis help destination
NAME
artemis destination - Destination tools group (create|delete) (example
./artemis destination create)

SYNOPSIS
artemis destination
artemis destination create [--durable] --name [--type ]
[--verbose] [--url ] [--password ]
[--address

] [--bindings ] [--filter ]
[--user ]
artemis destination delete --name [--removeConsumers]
[--type ] [--verbose] [--url ]
[--password ] [--user ]

COMMANDS
With no arguments, Display help information

    create
        create a queue or topic

        With --durable option, whether the queue is durable or not (default
        false)

        With --name option, destination name

        With --type option, type of destination to be created (one of
        jms-queue, topic and core-queue, default jms-queue

        With --verbose option, Adds more information on the execution

        With --url option, URL towards the broker. (default:
        tcp://localhost:61616)

        With --password option, Password used to connect

        With --address option, address of the core queue (default queue's
        name)

        With --bindings option, comma separated jndi binding names (default
        null)

        With --filter option, queue's filter string (default null)

        With --user option, User used to connect

    delete
        delete a queue or topic

        With --name option, destination name

        With --removeConsumers option, whether deleting destination with
        consumers or not (default false)

        With --type option, type of destination to be created (one of
        jms-queue, topic and core-queue, default jms-queue

        With --verbose option, Adds more information on the execution

        With --url option, URL towards the broker. (default:
        tcp://localhost:61616)

        With --password option, Password used to connect

        With --user option, User used to connect

[clebertsuconic]

it looks cool on the inline help 👍