Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization - Reusing Antlr4ResultHandler Initialization #1107

Merged
merged 1 commit into from Aug 21, 2023

Conversation

Munmud
Copy link
Contributor

@Munmud Munmud commented Jul 27, 2023

Description

As mentioned in issue #1106,
This pull request aims to optimize the current implementation of the Antlr4ResultHandler initialization process, resulting in improved query processing time and reduced overhead. Currently, for each query made, the Antlr4ResultHandleris repeatedly initialized, leading to unnecessary performance bottlenecks. To address this issue, we propose initializing the handler only once and then reusing it for subsequent queries.

Copy link
Member

@dehowef dehowef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dehowef
Copy link
Member

dehowef commented Aug 18, 2023

@Munmud can you make this pull request for each of the previous PG versions? For PG 11,12,13, and 14? Thanks

@Munmud
Copy link
Contributor Author

Munmud commented Aug 19, 2023

Sure. Working on it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants