Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 1329 - agtype_to_int4 crash #1339

Merged
merged 1 commit into from
Nov 1, 2023

Commits on Nov 1, 2023

  1. Fix Issue 1329 - agtype_to_int4 crash

    Fixed issue 1329 where `agtype_to_int`<8,4,2> and `agtype_to_int4_array`
    crashed due to not properly checking input.
    
    As these functions take "any" input, the input has to be properly
    checked before casting it to a specific type. The input section
    assumed it was agtype, which caused crashes for non-agtypes.
    
    The functions `agtype_to_int`<8,4,2> will convert non-agtypes into
    agtype. However, there were no regression tests for this.
    
    The functions `agtype_to_int`<8,4,2> will convert non-agtypes to
    agtype ints but, did not for their string equivs. Meaning, passing
    a ('true') or ('3.14') would fail but, passing a (true) or (3.14)
    would not. This has been corrected for all 3 functions.
    
    TODO -
    The function `agtype_to_int4_array` only takes agtype, currently,
    and we should consider allowing it to take "any" types.
    
    Added regression tests.
    Added missing regression tests.
    jrgemignani committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2513141 View commit details
    Browse the repository at this point in the history