Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker Instruction added for accessing Postgres shell #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Munmud
Copy link
Contributor

@Munmud Munmud commented Dec 25, 2022

Instruction Added

  • Run docker container
  • Access CLI for age container
  • Access Postgres shell

Removed

  • Unnecessary new line in previous bash command

README.md Outdated
```
<h5> Create AGE docker container </h5>
<h5> Create age docker container for first time</h5>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can capitalize the age word here as it holds significance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the container name is case sensitive... Container won't run otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the title, affecting the case of the alphabet won't make any difference in the running of the code. The case-sensitive line is 193 specifying the image to pull.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

README.md Outdated
@@ -195,7 +193,23 @@ docker run \
apache/age
```

<h5> Or Run docker container if you previously worked with age container </h5>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, capitalize the age keyword here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the container name is case sensitive... Container won't run otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a task description so you can capitalize the alphabet here. The main script is line 199 which should be case sensitive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants