Changes to GatewayResourceProfile #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewayResourceProfile
machristie
requested changes
Jun 17, 2020
There was a problem hiding this comment.
Hi @vivekshresta , this looks pretty good. I've requested some changes, let me know if you have any questions.
| @@ -38,6 +41,21 @@ export default { | |||
| required: true | |||
| } | |||
| }, | |||
| methods: { | |||
| handleTypedInput() { | |||
| const evt = window.event; | |||
There was a problem hiding this comment.
The event is passed as the first parameter to event handlers in Vue. Please use that instead of window.event which is deprecated.
There was a problem hiding this comment.
| @@ -177,6 +183,13 @@ export default { | |||
| } | |||
| return "..."; | |||
| }, | |||
| getUserStorageQuota(token) { | |||
There was a problem hiding this comment.
Maybe rename token to quota or value?
vivekshresta
changed the base branch from
master
to
AIRAVATA-3315-storage-quotas
|
Hi @machristie , As discussed, I'm merging all my changes to a feature branch(AIRAVATA-3315-storage-quotas). Please let me know if you want me to change anything else. |
|
Looks good @vivekshresta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first cut as part of EPIC: https://issues.apache.org/jira/browse/AIRAVATA-3315. By adding a new entry called UserStoragePreference, an admin user can configure storage quotas for the users in the Gateway.
0 is the default value for the UserStorageQuota entry, and the frontend, instead of displaying the value 0, displays "N/A" letting know the client that there are no storage restrictions in the Gateway.
It doesn't make any sense for the storage quota entry to have a negative number. So the client-side code has validations to make sure any typed or pasted value in the UserStorageQuota entry does not store any negative values.