Fixes for refactored storages api #28
Conversation
.../scp-transport/src/main/java/org/apache/airavata/mft/transport/scp/SCPMetadataCollector.java
Outdated
Show resolved
Hide resolved
`childPath` specified in FetchResourceMetadataRequest should be the `resourcePath` for child directories as returned for the parent directory.
|
@DImuthuUpe I've added another fix, but I'm not sure if this is right. I know that SCPMetadataCollector.getFileResourceMetadata(String storageId, String resourcePath, String credentialToken) is getting called with the resourceId, not the storageId as the first argument, so I've fixed the implementation to work with that. But I noticed that you recently updated the interface of getFileResourceMetadata to take storageId (was: parentResourceId) as the first argument. So perhaps the bug is really in the code calling getFileResourceMetadata? |
|
@machristie This is an intentional change. There are 2 overloaded methods for getDirectoryResourceMetadata public DirectoryResourceMetadata getDirectoryResourceMetadata(String resourceId, String credentialToken) The first one is when you have a resource registered in the resource service. The second one is when you don't have a resource registered but you need to list files. I came up with the second one to avoid the overhead of registering resources for each storage but I see some possible issues with authorization. Maybe we need to change it back to public DirectoryResourceMetadata getDirectoryResourceMetadata(String parentResourceId, String resourcePath, String credentialToken) What do you think? |
|
@DImuthuUpe I've switched the methods back to taking a parentResourceId in the latest commit. |
No description provided.