Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker mode #49

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add docker mode #49

merged 1 commit into from
Sep 22, 2022

Conversation

PatrickPradier
Copy link

  • Add a Dockerfile to build a docker image based on master branch
  • Add a docker-compose.yml to launch multiple mft agents

@smarru
Copy link
Member

smarru commented Aug 25, 2022

Thanks for your contribution Patrick, the PR says work in progress, please let us know when it is ready for review

PatrickPradier
PatrickPradier commented Aug 25, 2022
View reviewed changes
docker/Dockerfile
RUN ["./build.sh"]

RUN touch ../airavata-mft/MFT-Agent-0.01/logs/airavata.log
RUN printf '#!/bin/bash\n_term() {\n./stop-consul.sh\n./stop-mft.sh\n}\ntrap _term SIGTERM\nif [[ "$1" == consul ]];then\n ./start-consul.sh linux\nfi\n./start-mft.sh\n./log.sh agent &\nchild=$!\nwait "$child"' > run.sh
Copy link
Author

@PatrickPradier PatrickPradier Aug 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is a bit ugly, I could replace it by adding a run.sh script in the repository.

@PatrickPradier PatrickPradier marked this pull request as ready for review August 25, 2022 14:27
DImuthuUpe
DImuthuUpe approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@DImuthuUpe DImuthuUpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickPradier for the PR. This looks great

@DImuthuUpe DImuthuUpe merged commit 455c8f5 into apache:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DImuthuUpe DImuthuUpe DImuthuUpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PatrickPradier @smarru @DImuthuUpe