Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRAVATA-2697] Update GroupResourceProfile methods in API server to use sharing API to enforce READ and WRITE rules #181

Merged
merged 6 commits into from Apr 11, 2018

Conversation

sachinkariyattin
Copy link
Contributor

Changes:

  • Made changes in AiravataServerHandler.java to enforce READ and WRITE permissions for GroupResourceProfile API methods.

Copy link
Contributor

@machristie machristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Sachin. However I don't see that you've updated methods like getGroupResourceList that return multiple values. What you'll need to do for those is query the sharing registry for all entities of that type and then query the registry with a list of only those "accessible" entities. You can see how this is done in searchExperiments for example.

@sachinkariyattin
Copy link
Contributor Author

@machristie Thanks for the review. I have made the suggested changes.

@machristie
Copy link
Contributor

+1, looks good @sachinkariyattin

@machristie machristie merged commit 7d696e0 into apache:group-based-auth Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants