Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running upgrade_check command doesn't process DAGs located in zip files #15004

Closed
kosteev opened this issue Mar 25, 2021 · 2 comments
Closed

Running upgrade_check command doesn't process DAGs located in zip files #15004

kosteev opened this issue Mar 25, 2021 · 2 comments
Labels
kind:bug This is a clearly a bug upgrade-check upgrade-check CLI won't fix

Comments

@kosteev
Copy link
Contributor

kosteev commented Mar 25, 2021

Description
"airflow upgrade_check" command should consider that DAGs can be located in zip archives, as well as scheduler does.

Use case / motivation
User stores DAGs in zip archive file and willing to upgrade their Airflow instance from 1.10.15 version to 2.0. They want to run "airflow upgrade_check" command and see the correct report in this case.

Right now, for 1.3.0 version of "apache-airflow-upgrade-check" command doesn't fail in this scenario, it just skips all files except python modules.
@kosteev kosteev added the kind:feature Feature Requests label Mar 25, 2021
@eladkal eladkal added kind:bug This is a clearly a bug upgrade-check upgrade-check CLI and removed kind:feature Feature Requests labels Mar 25, 2021
@eladkal eladkal added this to the Airflow Upgrade Check - 1.4.0 milestone Mar 25, 2021
@ShakaibKhan ShakaibKhan mentioned this issue Apr 1, 2021
Closed
@ShakaibKhan
Copy link
Contributor

Hey,
I am trying to patch this issue and have a PR up #15123 was wondering if I could get some guidance on testing my change.

@eladkal eladkal removed this from the Airflow Upgrade Check - 1.4.0 milestone Jun 26, 2021
@eladkal
Copy link
Contributor

eladkal commented Jun 26, 2021

Closing as there will be no more releases of upgrade check

@eladkal eladkal closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug This is a clearly a bug upgrade-check upgrade-check CLI won't fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kosteev @ShakaibKhan @eladkal