Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breeze should load local tmux configuration in 'breeze start-airflow' #15416

Closed
pateash opened this issue Apr 17, 2021 · 6 comments · Fixed by #15454
Closed

breeze should load local tmux configuration in 'breeze start-airflow' #15416

pateash opened this issue Apr 17, 2021 · 6 comments · Fixed by #15454
Labels
kind:feature Feature Requests

Comments

@pateash
Copy link
Contributor

pateash commented Apr 17, 2021

Description

Currently, when we run

breeze start-airflow

breeze doesn't load local tmux configuration file .tmux.conf and we get default tmux configuration inside the containers.

Use case / motivation

Breeze must load local tmux configuration in to the containers and developers should be able to use their local configurations.

Are you willing to submit a PR?
YES

Related Issues
None

@pateash pateash added the kind:feature Feature Requests label Apr 17, 2021
@pateash pateash changed the title Breeze should load local tmux configuration in 'breeze start-airflow' breeze should load local tmux configuration in 'breeze start-airflow' Apr 17, 2021
@mik-laj
Copy link
Member

mik-laj commented Apr 19, 2021

SGTM. Can you submit a PR?

@uranusjr
Copy link
Member

uranusjr commented Apr 19, 2021

I wondered about this a while ago (mostly because I don’t want to repeatedly set mouse on). The problem is any slightly sophisticated local tmux setup would contain a lot of dependencies and it’s not realistic to pull them all into the container. So maybe a better approach would be have a directory in the repository; if the user puts a (git-ignored) .tmux.conf file in it, the file is mounted to the container’s ~/.tmux.conf.

@pateash
Copy link
Contributor Author

pateash commented Apr 20, 2021

SGTM. Can you submit a PR?

Yes I will.

@potiuk
Copy link
Member

potiuk commented Apr 20, 2021

We already have similar mechanism for reading user-supplied env variables placed in files/airflow-breeze-config folder.

if [[ -d "${AIRFLOW_BREEZE_CONFIG_DIR}" && \

It could be done in a very similar way .

@pateash
Copy link
Contributor Author

pateash commented Apr 20, 2021

We already have similar mechanism for reading user-supplied env variables placed in files/airflow-breeze-config folder.

if [[ -d "${AIRFLOW_BREEZE_CONFIG_DIR}" && \

It could be done in a very similar way .

thanks @potiuk, let me check.

@pateash
Copy link
Contributor Author

pateash commented Apr 20, 2021

PR #15454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants