Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore the possibility of generic SqlToGcsOperator #21599

Open
1 task done
eladkal opened this issue Feb 15, 2022 · 3 comments
Open
1 task done

Explore the possibility of generic SqlToGcsOperator #21599

eladkal opened this issue Feb 15, 2022 · 3 comments
Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue provider:google Google (including GCP) related issues

Comments

@eladkal
Copy link
Contributor

eladkal commented Feb 15, 2022

Body

Recently SqlToS3Operator was added in PR #20807 (It also deprecated MySqlToS3Operator)

In Google provider Currently we have BaseSQLToGCSOperator with PrestoToGCSOperator, MSSQLToGCSOperator, MySQLToGCSOperator, OracleToGCSOperator, PostgresToGCSOperator, TrinoToGCSOperator, DummySQLToGCSOperator

This task is to check if we can have a generic SqlToGCSOperator just like there is for AWS so we won't need class per each provider...

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added provider:google Google (including GCP) related issues good first issue kind:task A task that needs to be completed as part of a larger issue labels Feb 15, 2022
@kadai0308
Copy link
Contributor

Hi eladkal, Can I take this one as my first issue? I already went through the PR #20807
and later I will check each implementation of XXXToGCSOperator to see is it possible to implement a generic SqlToGCSOperator to replace all of them.

@eladkal
Copy link
Contributor Author

eladkal commented Feb 20, 2022

sure assigned to you

@kadai0308
Copy link
Contributor

Hi @eladkal, when I investigated the presto_to_gcs operator & trino_to_gcs operator found the key of integer & float in their type map is different with others to_gcs operator, I think it might be a bug, so raise a PR #21700.
Can you help me check on that? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue provider:google Google (including GCP) related issues
Projects
None yet
Development

No branches or pull requests

2 participants