Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline trigger dag UX #22408

Open
bbovenzi opened this issue Mar 21, 2022 · 5 comments
Open

Streamline trigger dag UX #22408

bbovenzi opened this issue Mar 21, 2022 · 5 comments
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 21, 2022

Problem:

Triggering a dag run is a relatively simple process conceptually yet a user is run through multiple different redirects and views. This results in a clunky experience that is slower, causes one to lose context and even end up on a page where they didn't even start on.

Solution:

Handle the API calls within the client and have everything happen within a modal on the user's current page. The modal can handle confirmation events too.
This means that we should copy the logic from the Task Instance modal in dag.html and dag.js, create a new Trigger Dag modal, and update the relevant parts of views.py

@bbovenzi bbovenzi created this issue from a note in AIP-38: Modern Web Application (To Do) Mar 21, 2022
@bbovenzi bbovenzi added the area:UI Related to UI/UX. For Frontend Developers. label Mar 21, 2022
@bbovenzi bbovenzi added kind:feature Feature Requests area:UI Related to UI/UX. For Frontend Developers. and removed area:UI Related to UI/UX. For Frontend Developers. labels Mar 21, 2022
@maxnathaniel
Copy link
Contributor

I can work on this if this is still relevant

@potiuk
Copy link
Member

potiuk commented Jan 25, 2023

Assigned you @maxnathaniel. I think checking it should be the first thing to do and if you find it's fixed, making a comment about it would be useful as well, so that we can close the ticket :).

@bbovenzi
Copy link
Contributor Author

@maxnathaniel We should be merging this PR soon, so you could branch off of that and get started. I think the next useful step would be to convert the trigger UI from a separate page to a modal. Like the actions in the graph and gantt views.

@maxnathaniel
Copy link
Contributor

@bbovenzi ok great! Will take a look at that

@bbovenzi bbovenzi moved this from To Do to In progress in AIP-38: Modern Web Application Jan 31, 2023
@maxnathaniel
Copy link
Contributor

@bbovenzi apologies, have been busy with work. Will continue where I had left off with this task this week and aim to push out something by end of week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Development

No branches or pull requests

3 participants