Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading scheduler health message when using SequentialExecutor #23081

Open
1 task done
eladkal opened this issue Apr 19, 2022 · 1 comment
Open
1 task done

Misleading scheduler health message when using SequentialExecutor #23081

eladkal opened this issue Apr 19, 2022 · 1 comment
Labels
affected_version:main_branch Issues Reported for main branch area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues

Comments

@eladkal
Copy link
Contributor

eladkal commented Apr 19, 2022

Body

In the UI we have a message that warns in case the scheduler isn't running:
The scheduler does not appear to be running. Last heartbeat was received X minutes ago.
https://github.com/apache/airflow/blame/5144bedcee76466a79eea0b2b6137e5899dc73bd/airflow/www/templates/airflow/main.html#L60-L71

This message however is confusing for SequentialExecutor.
In SequentialExecutor we can run only 1 task so while a task is running the scheduler is not sending health checks which results in this message but it make sense that there is no heartbeat because there is a task that occupy the slot.

My suggestion is to make the message be conditional

in case of Sqlite / Sequential executor + no active runs -> It's OK to show the message if scheduler is not live.
in case of Sqlite / Sequential executor + active run -> Message should not appear.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added area:UI Related to UI/UX. For Frontend Developers. affected_version:main_branch Issues Reported for main branch labels Apr 19, 2022
@bbovenzi
Copy link
Contributor

We should move this logic from main.html and handle it inside the webserver in views.py and pass a single variable of is_scheduler_running to the UI.

@bbovenzi bbovenzi added the area:webserver Webserver related Issues label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:main_branch Issues Reported for main branch area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Development

No branches or pull requests

2 participants