Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudSQL proxy download doesn't work for x86_64 systems #23501

Closed
2 tasks done
denver-at-takeoff opened this issue May 5, 2022 · 5 comments
Closed
2 tasks done

CloudSQL proxy download doesn't work for x86_64 systems #23501

denver-at-takeoff opened this issue May 5, 2022 · 5 comments
Labels
area:core duplicate Issue that is duplicated kind:bug This is a clearly a bug

Comments

@denver-at-takeoff
Copy link

Apache Airflow version

2.3.0 (latest released)

What happened

The automatic cloud_sql_proxy download via the CloudSqlProxyRunner is not working because the environment is using the uname -a info and it is pull x86_64. The url for the cloud_sql_proxy binaries are no longer using x86_64. Instead, the binaries are now using amd64 indicator.

What you think should happen instead

The hardcoded process should be opened up to include a user defined option via an extra parameter for the CloudSQLDatabaseHook and other hooks. This would hedge for future URL updates without the need for a full blown release.

How to reproduce

Run in an environment that has no local copy of the cloud_sql_proxy and the uname -a gives x86_64.

Operating System

Linux

Versions of Apache Airflow Providers

No response

Deployment

Composer

Deployment details

No response

Anything else

This will happen every time the _download_sql_proxy_if_needed is ran in an x86_64 environment.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@denver-at-takeoff denver-at-takeoff added area:core kind:bug This is a clearly a bug labels May 5, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented May 5, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk
Copy link
Member

potiuk commented May 5, 2022

This is a provider, not Airflow 2.3.0 issue. It has been already fixed #23299 and will be released in the next Google provider (which you wil be able to upgrade to or which will undoubtedly become default in Airflow 2.3.1)

@potiuk potiuk added the duplicate Issue that is duplicated label May 5, 2022
@potiuk
Copy link
Member

potiuk commented May 5, 2022

Closing as duplicate.

@potiuk potiuk closed this as completed May 5, 2022
@denver-at-takeoff
Copy link
Author

Thanks didn't catch that previous ticket when I initially search for this issue.

@potiuk
Copy link
Member

potiuk commented May 5, 2022

No worries. Not always easy indeed. I KNEW there was a change but I had trouble finding it too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core duplicate Issue that is duplicated kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

2 participants