Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_wrap setting for webserver is not working #24721

Open
2 tasks done
ming-zhang-SN opened this issue Jun 29, 2022 · 6 comments
Open
2 tasks done

default_wrap setting for webserver is not working #24721

ming-zhang-SN opened this issue Jun 29, 2022 · 6 comments
Assignees
Labels
affected_version:2.3 Issues Reported for 2.3 area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug Stale Bug Report

Comments

@ming-zhang-SN
Copy link

Apache Airflow version

2.3.2 (latest released)

What happened

The DAG logs are not wrapped even I set default_wrap in airflow.cfg to True.
That may cause by this line I think:
https://github.com/apache/airflow/blob/main/airflow/www/static/js/dag_code.js#L25

I tried with the following code and worked:

$('pre > code').toggleClass('wrap');

What you think should happen instead

No response

How to reproduce

No response

Operating System

Ubuntu 19.10

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ming-zhang-SN ming-zhang-SN added area:core kind:bug This is a clearly a bug labels Jun 29, 2022
@uranusjr uranusjr added area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels Jun 30, 2022
@eladkal eladkal added the affected_version:2.3 Issues Reported for 2.3 label Jul 5, 2022
@bbovenzi
Copy link
Contributor

@pierrejeambrun We may want to make sure this config is passed to the new grid view logs too.

@pierrejeambrun
Copy link
Member

Yes good idea. I'll open a PR for that :)

@bbovenzi
Copy link
Contributor

@ming-zhang-SN do you still want to open a PR to fix this?

@pierrejeambrun
Copy link
Member

@ming-zhang-SN We made the update for the grid view, do you want to open a PR for the log page ?

@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 1, 2023

If anyone else wants to pick up this issue. You will want to add a meta tag for wrapped to the ti_log html file. Then to use getMetaValue() to get that value in the js file and add the wrap class to the code block here.

We need to just migrate to a single logs view: #29856

Copy link

github-actions bot commented Apr 4, 2024

This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activity on this issue. Kindly asking to recheck the report against latest Airflow version and let us know if the issue is reproducible. The issue will be closed in next 30 days if no further activity occurs from the issue author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.3 Issues Reported for 2.3 area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug Stale Bug Report
Projects
None yet
Development

No branches or pull requests

5 participants