Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't configure Kubernetes and Celery workers in Helm Chart #28880

Open
2 tasks done
csp33 opened this issue Jan 12, 2023 · 5 comments
Open
2 tasks done

Can't configure Kubernetes and Celery workers in Helm Chart #28880

csp33 opened this issue Jan 12, 2023 · 5 comments
Assignees
Labels
area:helm-chart Airflow Helm Chart good first issue kind:feature Feature Requests

Comments

@csp33
Copy link
Contributor

csp33 commented Jan 12, 2023

Official Helm Chart version

1.7.0 (latest released)

Apache Airflow version

2.4.3

Kubernetes Version

1.25

Helm Chart configuration

No response

Docker Image customizations

No response

What happened

Current Helm chart uses the "workers" section to configure Kubernetes or Celery workers parameters (resources, affinity, etc.).
However, when using CeleryKubernetesExecutor, the "workers" section is used to configure the Celery ones, making Kubernetes workers settings available only via podTemplateFile, which can be difficult to manage.

I suggest splitting "workers" into "kubernetesWorkers" (used in pod_template_file) and "celeryWorkers" (used by the celery ones)

What you think should happen instead

Helm Chart should allow to configure both kind of workers in an easy way

How to reproduce

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@csp33 csp33 added area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug labels Jan 12, 2023
@potiuk potiuk added kind:feature Feature Requests good first issue and removed kind:bug This is a clearly a bug labels Jan 19, 2023
@potiuk
Copy link
Member

potiuk commented Jan 19, 2023

Why not - if someoene would like to pick it, i marked it as good first issue.

@csp33
Copy link
Contributor Author

csp33 commented Jan 20, 2023

I could take this one. How about this proposal? values defined at the "workers" level will be taken by both celery & k8s.

workers:
  safeToEvict: false
  celery:
    resources: 
      limits:
        cpu: 1
        memory: 1Gi
      requests:
        cpu: 1
        memory: 1Gi
  kubernetes:
    resources:
      limits:
        cpu: 240m
        memory: 875Mi
      requests:
        cpu: 240m
        memory: 875Mi

@potiuk

@potiuk
Copy link
Member

potiuk commented Jan 21, 2023

Just make a PR - we (or others) can easier discuss it there.

@amoghrajesh
Copy link
Contributor

@potiuk if nobody is actively working on this, I would like to take it up.

@potiuk
Copy link
Member

potiuk commented Feb 19, 2023

Feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart good first issue kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants