Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounting all volume in init/side containers breaks my setup (introduced in PR 27420) #29426

Closed
2 tasks done
iJanki-gr opened this issue Feb 8, 2023 · 2 comments
Closed
2 tasks done
Labels

Comments

@iJanki-gr
Copy link
Contributor

iJanki-gr commented Feb 8, 2023

Official Helm Chart version

1.8.0 (latest released)

Apache Airflow version

2.5.1

Kubernetes Version

1.24.4

Helm Chart configuration

No response

Docker Image customizations

No response

What happened

I tried out the new 1.8.0 release of the chart. I found there is a backwards incompatible change introduced in
#27420 that causes all extraVolumes and extraMounts to be added to all init and sidecars.

This causes issues for us when using subPath mounts causing folders to be wrongly created by init containers that have nothing to do with the volume.

What you think should happen instead

Can this opinionated change be at least opt-out, guarded by some value?
Something like:

mountAllExtraVolumes: true

We would like to keep using this chart as is without forking.

How to reproduce

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@iJanki-gr iJanki-gr added area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug labels Feb 8, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 8, 2023

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk
Copy link
Member

potiuk commented Feb 8, 2023

Can you please explain what is the exact problem you have and why it gets broken ? I think any decisions to change anything should be based on the assessment if this is a product problem or approach of yours that is the problem. There are good reason why volumes are mounted now (see the original PR) and adding options is often worse than opinionated decisions - maybe just you use the chart wrongly and it's better from the product point of view is you change it rather than add another option - especially that you would also need to explain consequences and maybe your case will have a variant when mounting volumes is still needed.

Can you please explain the problem you have in detail?

@potiuk potiuk added pending-response and removed kind:bug This is a clearly a bug labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants