Improve grid view height calculations #29563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
bbovenzi
commented
Feb 22, 2023
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| body { | |||
| position: relative; | |||
| padding: 70px 0 100px; | |||
There was a problem hiding this comment.
We don't need such large bottom padding.
jedcunningham
approved these changes
Feb 23, 2023
bbovenzi
force-pushed
the
fix-grid-view-heights
branch
from
214049c
to
fe72efe
Compare
pierrejeambrun
added
the
changelog:skip
pierrejeambrun
added
type:improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29367 I address the issue of the grid view heights being too short simply by doubling the minimum height. This PR tries to come up with a better solution. Instead of calculating the window height and a top/bottom offset, we simply sit a maxHeight for the parent component of the entire grid view and then subtract the topOffset of each component that needs a scroll overflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.