Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing of Apache Airflow 2.5.3rc2 #30337

Closed
9 of 28 tasks
pierrejeambrun opened this issue Mar 27, 2023 · 12 comments
Closed
9 of 28 tasks

Status of testing of Apache Airflow 2.5.3rc2 #30337

pierrejeambrun opened this issue Mar 27, 2023 · 12 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Mar 27, 2023

We have a kind request for all the contributors to the latest Apache Airflow RC 2.5.3rc2.

Could you please help us to test the RC versions of Airflow?

Please let us know in the comment if the issue is addressed in the latest RC.

Thanks to all who contributed to the release (probably not a complete list!):
@meujin @josh-fell @vemikhaylov @ashb @tirkarthi @farhan0syakir @auvipy @antoniocorralsierra @junho85 @SamWheating @PannagaMayya @mik-laj @IAL32 @eladkal @ephraimbuddy @aaronsatae @potiuk @yuqian90 @frankbreetz @milczar @badrisrinivas9 @jakubno @michaelmicheal @boushphong @hussein-awala @jcobb-healx @tanvn

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@pierrejeambrun pierrejeambrun added kind:meta High-level information important to the community testing status Status of testing releases labels Mar 27, 2023
@raphaelauv
Copy link
Contributor

raphaelauv commented Mar 27, 2023

the graph view zoom on the first task , it's super weird

Screenshot from 2023-03-28 00-07-17

if I unzoom it look better

Screenshot from 2023-03-28 00-09-18

@antoniocorralsierra
Copy link
Contributor

DagProcess running as standalone process is working fine, the restart have disappeared. Congrats!!

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Mar 28, 2023

@raphaelauv I think it comes from #29971 which remove the 1.5 max zoomScale cap. (I would say that this is the indented behavior, I agree, it's really big, I'm not a big fan), but the fact that some nodes can be missing from the first focus is not great.

@potiuk @ephraimbuddy @bbovenzi, Should we fix that and go for rc2 ? (I think yes)

@potiuk
Copy link
Member

potiuk commented Mar 28, 2023

@raphaelauv I think it comes from #29971 which remove the 1.5 max zoomScale cap. (I would say that this is the indented behavior, I agree, it's really big, I'm not a big fan), but the fact that some nodes can be missing from the first focus is not great.

@potiuk @ephraimbuddy @bbovenzi, Should we fix that and go for rc2 ? (I think yes)

I think it is more of an easthetic thing / UX than technical issue. The question is (I have not looked at it yet) - is it something that will happen with every graph every time or only with some almost-empty-non-connected-and-really-non-realistic graphs like this one above? If the former - yes, we should fix it IMHO, if the latter - I think we do not have to fix it.

@hussein-awala
Copy link
Member

I tested:

and they both work as expected.

But I agree with @raphaelauv about the graph default zoom level, it's weird and annoying.

The question is (I have not looked at it yet) - is it something that will happen with every graph every time or only with some almost-empty-non-connected-and-really-non-realistic graphs like this one above?

@potiuk it's the former, I have this zoom level on all the graphs for all the dag and dag runs. IMO we should fix it and go for rc2.

@potiuk
Copy link
Member

potiuk commented Mar 28, 2023

@potiuk it's the former, I have this zoom level on all the graphs for all the dag and dag runs. IMO we should fix it and go for rc2

Then yes.

@ephraimbuddy
Copy link
Contributor

@potiuk it's the former, I have this zoom level on all the graphs for all the dag and dag runs. IMO we should fix it and go for rc2

Then yes.

Agree too

@bbovenzi
Copy link
Contributor

Fix: #30355

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Mar 29, 2023

Due to the graph zoom issue in rc1, rc2 has been made. I think we can safely assume that what was tested for rc1 is still working in rc2. Feel free to do more testing. The issue has been updated to target 2.5.3rc2

@pierrejeambrun pierrejeambrun changed the title Status of testing of Apache Airflow 2.5.3rc1 Status of testing of Apache Airflow 2.5.3rc2 Mar 29, 2023
@potiuk
Copy link
Member

potiuk commented Mar 30, 2023

  • which is actually a fix to my fix - neither on the list of issues here nor in release notes. The change is cherry-picked and technically it's a fix to a fix, so no big deal. Just wonder how it was lost from both release notes and issue status here.

@josh-fell
Copy link
Contributor

#30131 Looks good.

Thanks for organizing @pierrejeambrun!

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Apr 1, 2023

Thanks to everyone that helped testing 2.5.3rc1 and 2.5.3rc2. 🙏

Closing as 2.5.3 has been released based on 2.5.3rc2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

8 participants