Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown default and adjust tutorial to use 42 as default for proof #31400

Conversation

jscheffl
Copy link
Contributor

closes: #31399

This PR fixes the bug that drop-downs in trigger Form are not correctly initialized with the defined default value. In Airflow 2.6.1 always the first value is picked on the UI.

Would have been better if I would have read the HTML specs before ( :-D ) but at least I found my own contributed bug.

To make this visible better I also changed the default in the tutorial DAG to be not the first item in the list. If this would have been before like this I would have seen the bug earlier.

How to test?

  • Open the "example_params_ui_tutorial" DAG form and see that defait of the dropdown is "value 42".

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 18, 2023
@pierrejeambrun pierrejeambrun merged commit 58aab11 into apache:main May 21, 2023
42 checks passed
@eladkal eladkal added this to the Airflow 2.6.2 milestone Jun 8, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 9, 2023
@jscheffl jscheffl deleted the bugfix/31399-fix-dropdown-default-in-trigger-ui branch October 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger UI Form Dropdowns with enums do not set default correct
3 participants