Fix number param html type in trigger template #31980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange only type value Signed-off-by: Hussein Awala <hussein@awala.fr>
hussein-awala
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
uranusjr
reviewed
Jun 19, 2023
uranusjr
reviewed
Jun 19, 2023
| {%- if "integer" in form_details.schema.type %} valuetype="number" {% elif "number" in form_details.schema.type %} valuetype="decimal" {%- endif %} | ||
| {%- if "integer" in form_details.schema.type or "number" in form_details.schema.type %} valuetype="number"{% endif %} |
There was a problem hiding this comment.
So just to make sure, this PR reverts this line from #31946 and the aggregated change is only line 120, right?
There was a problem hiding this comment.
Yes, because we need just to change type attribute
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
uranusjr
approved these changes
Jun 19, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Keep valuetype="number" for both param number and integer types and change only type value Signed-off-by: Hussein Awala <hussein@awala.fr> * Update airflow/www/templates/airflow/trigger.html Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Signed-off-by: Hussein Awala <hussein@awala.fr> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 2327718)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #31930
related: #31946
It seems that when I changed the
valuetypetodecimal, the value was passed to the API a string which raise a validation exception in the dag run. Changing just the type to decimal is sufficient to fix the initial issue, for ex:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.