Return None if an XComArg fails to resolve in a multiple_outputs Task #32027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jun 21, 2023
Tasks with multiple_outputs set to True returns XComs with different keys which are not known to Airflow. Because they have multiple_outputs set, we should return None if we can't find the XCom, just like we return None when the key is equal to XCOM_RETURN_KEY known to Airflow. Closes: apache#29199
ephraimbuddy
force-pushed
the
multioutputs-error
branch
from
d61e964
to
d8c43db
Compare
uranusjr
approved these changes
Jun 21, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
…apache#32027) * Return None if an XComArg fails to resolve in a multiple_outputs Task Tasks with multiple_outputs set to True returns XComs with different keys which are not known to Airflow. Because they have multiple_outputs set, we should return None if we can't find the XCom, just like we return None when the key is equal to XCOM_RETURN_KEY known to Airflow. Closes: apache#29199 * Apply suggestions from code review
ephraimbuddy
added a commit
that referenced
this pull request
Jul 6, 2023
…#32027) * Return None if an XComArg fails to resolve in a multiple_outputs Task Tasks with multiple_outputs set to True returns XComs with different keys which are not known to Airflow. Because they have multiple_outputs set, we should return None if we can't find the XCom, just like we return None when the key is equal to XCOM_RETURN_KEY known to Airflow. Closes: #29199 * Apply suggestions from code review (cherry picked from commit 79eac76)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks with multiple_outputs set to True returns XComs with different keys which are not known to Airflow. Because they have multiple_outputs set, we should return None if we can't find the XCom, just like we return None when the key is equal to XCOM_RETURN_KEY known to Airflow.
Closes: #29199