Separate out advanced logging configuration #32131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:logging
area:providers
kind:documentation
provider:google
potiuk
requested review from
jedcunningham,
dstandish,
eladkal,
pankajkoti and
pankajastro
uranusjr
reviewed
Jun 26, 2023
pankajkoti
approved these changes
Jun 26, 2023
...-airflow/administration-and-deployment/logging-monitoring/advanced-logging-configuration.rst
Show resolved
Hide resolved
|
cc: @sunank200 |
Adaverse
reviewed
Jun 26, 2023
...-airflow/administration-and-deployment/logging-monitoring/advanced-logging-configuration.rst
Outdated
Show resolved
Hide resolved
potiuk
force-pushed
the
slightlty-restructure-logging-docs
branch
2 times, most recently
from
578af7a
to
20ed43b
Compare
The "advanced logging configuration" applies not only to task logs but also to component logs and you can use it not only to configure custom way how task logs are created but also custom way how "regular" component logs are created. This has been a source of confusion for those who wanted to configure (for example) elasticsearch or opensearch for the whole airflow deployment, because the "advanced configuration" and how to modify standard configuration chapter was a small section in "task logging". This change extracts "advanced logging configuration" to separate page right under the "logging and monitoring" and directs the user from the "task" logging section to this page. It also adds a bit more explanation on how standard Python logging framework is leveraged here and links to Python logging documentation for those who never used it before, to understand more about Loggers, Handlers and Formatters. Co-authored-by: Akash Sharma <35839624+Adaverse@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
potiuk
force-pushed
the
slightlty-restructure-logging-docs
branch
from
20ed43b
to
0c7e0ef
Compare
|
:D Look for some approvals :) |
eladkal
approved these changes
Jun 30, 2023
hussein-awala
approved these changes
Jun 30, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 30, 2023
The change apache#32131 restructured some of the code for documentation and it broke references to apache-airlfow from "providers" doc package - it has not been visible in selective PR (not sure the reason) but this PR fixes it.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 30, 2023
When provider docs in "docs/apache-airflow-providers" changed, and selective docs build was used, the "apache-airflow-providers" package was not added to the filter - thus errors in those docs were not checked. This caused apache#32131 to fail the main build (fixed in the apache#32282). Added logic to handle this case.
potiuk
added a commit
that referenced
this pull request
Jun 30, 2023
…32284) When provider docs in "docs/apache-airflow-providers" changed, and selective docs build was used, the "apache-airflow-providers" package was not added to the filter - thus errors in those docs were not checked. This caused #32131 to fail the main build (fixed in the #32282). Added logic to handle this case.
potiuk
added a commit
that referenced
this pull request
Jul 2, 2023
…32284) When provider docs in "docs/apache-airflow-providers" changed, and selective docs build was used, the "apache-airflow-providers" package was not added to the filter - thus errors in those docs were not checked. This caused #32131 to fail the main build (fixed in the #32282). Added logic to handle this case. (cherry picked from commit ba05a1e)
potiuk
added a commit
that referenced
this pull request
Jul 2, 2023
The "advanced logging configuration" applies not only to task logs but also to component logs and you can use it not only to configure custom way how task logs are created but also custom way how "regular" component logs are created. This has been a source of confusion for those who wanted to configure (for example) elasticsearch or opensearch for the whole airflow deployment, because the "advanced configuration" and how to modify standard configuration chapter was a small section in "task logging". This change extracts "advanced logging configuration" to separate page right under the "logging and monitoring" and directs the user from the "task" logging section to this page. It also adds a bit more explanation on how standard Python logging framework is leveraged here and links to Python logging documentation for those who never used it before, to understand more about Loggers, Handlers and Formatters. Co-authored-by: Akash Sharma <35839624+Adaverse@users.noreply.github.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit ead2530)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "advanced logging configuration" applies not only to task logs but also to component logs and you can use it not only to configure custom way how task logs are created but also custom way how "regular" component logs are created.
This has been a source of confusion for those who wanted to configure (for example) elasticsearch or opensearch for the whole airflow deployment, because the "advanced configuration" and how to modify standard configuration chapter was a small section in "task logging".
This change extracts "advanced logging configuration" to separate page right under the "logging and monitoring" and directs the user from the "task" logging section to this page. It also adds a bit more explanation on how standard Python logging framework is leveraged here and links to Python logging documentation for those who never used it before, to understand more about Loggers, Handlers and Formatters.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.