Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow context key args to not provide a default #33430

Merged
merged 1 commit into from Aug 20, 2023

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Aug 16, 2023

Documentation updated to reflect this. I did not change any of the examples since the type hint part is more difficult to deal with, maybe even impossible (without significant feature addition in typing).

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY NICE. One really small NIT.

docs/apache-airflow/tutorial/taskflow.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM +1

@eladkal eladkal added this to the Airflow 2.8.0 milestone Aug 18, 2023
@eladkal eladkal added the type:improvement Changelog: Improvements label Aug 18, 2023
@uranusjr uranusjr merged commit c9452c8 into apache:main Aug 20, 2023
42 checks passed
@uranusjr uranusjr deleted the task-deco-func-no-need-none branch August 20, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants