Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log appropriate trigger cancel reasons #33877

Closed
1 of 2 tasks
pankajkoti opened this issue Aug 29, 2023 · 2 comments
Closed
1 of 2 tasks

Log appropriate trigger cancel reasons #33877

pankajkoti opened this issue Aug 29, 2023 · 2 comments
Labels

Comments

@pankajkoti
Copy link
Member

Description

Continuing the conversation from the topic covered in #31720, we successfully managed the cancellation resulting from trigger timeout within pull request #31757. Within the same pull request, a generic cancellation log was introduced. This log, however, also surfaces during instances where the trigger completes successfully. To address this matter, pull request #33874 is in progress, aiming to eliminate this generalized trigger log. This alteration is prompted by user feedback, revealing that the presence of the general log caused confusion by implying errors even in cases of successful triggers.

In accordance with the deliberations in issue #31720, it is necessary for us to implement a system that facilitates the communication of pertinent causes for diverse trigger cancellation scenarios. And we need to then incorporate logic designed to convey specific cancellation explanations and subsequently record corresponding detailed cancellation logs.

Use case/motivation

No response

Related issues

#31720

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@pankajkoti pankajkoti added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Aug 29, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 29, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@Taragolis Taragolis removed the needs-triage label for new issues that we didn't triage yet label Oct 16, 2023
@RNHTTR
Copy link
Collaborator

RNHTTR commented Nov 27, 2023

Closed by #33874

@RNHTTR RNHTTR closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants