Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update define-extra-link.rst #34547

Merged
merged 3 commits into from Oct 4, 2023
Merged

Conversation

AchimGaedkeLynker
Copy link
Contributor

Add necessary imports for type hints in examples.

The examples look like they are intended to be self-contained and should work when cutting and pasting them into a (plugin) python file. Sadly the imports are incomplete.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 22, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal added this to the Airflow 2.7.2 milestone Sep 28, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Sep 28, 2023
Add necessary imports for type hints in examples.
sorry, I have offended the gods of PEP8
@AchimGaedkeLynker
Copy link
Contributor Author

@eladkal - what else needs doing here?

@uranusjr uranusjr merged commit 8d6acce into apache:main Oct 4, 2023
43 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 4, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ephraimbuddy pushed a commit that referenced this pull request Oct 29, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit 8d6acce)
ephraimbuddy pushed a commit that referenced this pull request Oct 30, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
(cherry picked from commit 8d6acce)
@AchimGaedkeLynker AchimGaedkeLynker deleted the patch-1 branch January 16, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants