Unify mapped task group lookup logic #34637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lookup logic in operators is identical to the one on task groups (in a function of the same name), so let's reuse the logic instead of having to maintain two loops with only slightly different code. I thought about getting rid of this function on AbstractOperator altogether, but the 'self.task_group is None' case is annoying enough I feel it's still better to keep the extra abstraction layer.
uranusjr
force-pushed
the
refactor-iter-mapped-task-group
branch
from
f80733b
to
8fbf9c3
Compare
eladkal
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor refactoring.
The lookup logic in operators is identical to the one on task groups (in a function of the same name), so let's reuse the logic instead of having to maintain two loops with only slightly different code.
I thought about getting rid of this function on AbstractOperator altogether, but the
self.task_group is Nonecase is annoying enough I feel it's still better to keep the extra abstraction layer.