Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit WTForms to below 3.1.0 #34943

Merged
merged 1 commit into from Oct 14, 2023
Merged

Limit WTForms to below 3.1.0 #34943

merged 1 commit into from Oct 14, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 14, 2023

WTForms 3.1.0 released 10th of October 2023 introduced a breaking change in the way QuerySelectChoices fields are handled.
See details in dpgaspar/Flask-AppBuilder#2137


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

WTForms 3.1.0 released 10th of October 2023 introduced a breaking change in the way
QuerySelectChoices fields are handled.
See details in dpgaspar/Flask-AppBuilder#2137
@potiuk potiuk merged commit 6b5d369 into apache:main Oct 14, 2023
18 checks passed
@potiuk potiuk deleted the limit-wtforms branch October 14, 2023 17:10
@eladkal eladkal added this to the Airflow 2.7.3 milestone Oct 14, 2023
@potiuk potiuk mentioned this pull request Oct 14, 2023
@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 14, 2023
@Taragolis Taragolis mentioned this pull request Oct 16, 2023
2 tasks
potiuk added a commit that referenced this pull request Oct 29, 2023
WTForms 3.1.0 released 10th of October 2023 introduced a breaking change in the way
QuerySelectChoices fields are handled.
See details in dpgaspar/Flask-AppBuilder#2137

(cherry picked from commit 6b5d369)
@Piatachock
Copy link
Contributor

Piatachock commented Oct 31, 2023

WTForms==3.1.0 is fixed in providers-constraints: https://raw.githubusercontent.com/apache/airflow/constraints-main/constraints-source-providers-3.8.txt
Which I believe is failing CI image building on my local Breeze installation:

Building CI Image for Python 3.8

...
 => ERROR [main 22/32] RUN bash /scripts/docker/install_airflow.sh
------
 > [main 22/32] RUN bash /scripts/docker/install_airflow.sh:
0.475 PATH=/root/.local/bin:/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
0.477 pip on path: /usr/local/bin/pip
0.891 Using pip: pip 23.3 from /usr/local/lib/python3.8/site-packages/pip (python 3.8)
0.891
0.891 Installing all packages with constraints and upgrade if needed
0.891
0.891 + pip install --root-user-action ignore --editable '.[devel_ci]' --constraint https://raw.githubusercontent.com/apache/airflow/constraints-main/constraints-source-providers-3.8.txt
2.448 Obtaining file:///opt/airflow
2.449   Preparing metadata (setup.py): started
5.446   Preparing metadata (setup.py): finished with status 'done'
6.211 WARNING: apache-airflow 2.8.0.dev0 does not provide the extra 'devel-ci'
6.482 INFO: pip is looking at multiple versions of apache-airflow[devel-ci] to determine which version is compatible with other requirements. This could take a while.
6.482 ERROR: Cannot install apache-airflow[devel-ci]==2.8.0.dev0 because these package versions have conflicting dependencies.
6.484
6.484 The conflict is caused by:
6.484     apache-airflow[devel-ci] 2.8.0.dev0 depends on WTForms<3.1.0
6.484     The user requested (constraint) wtforms==3.1.0
...

Shouldn't the constraint file be changed to reflect WTForms<3.1.0 version dependency? Or is it some problem on my local installation?

@potiuk tag you just in case

@potiuk
Copy link
Member Author

potiuk commented Oct 31, 2023

ABR - Always Be Rebased.

This limit has been removed few days later as FAB fixed the problem and we upgraded to latest version of FAB (FAB version is pinned in Airflow).

You are not living on the "edge enough".

@potiuk
Copy link
Member Author

potiuk commented Oct 31, 2023

#35085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants