Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide logical date and run id in trigger UI form #35284

Merged
merged 9 commits into from Nov 8, 2023
Merged

Hide logical date and run id in trigger UI form #35284

merged 9 commits into from Nov 8, 2023

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Oct 30, 2023 •
edited

This PR is an improvement based on the feedback raised in issue #34726 and optimizes the layout of the trigger UI form.

This PR changes:

  • Run ID and Logic date are now in the folded section of generated JSON config - why? Because most users don't know what this is and (most probably) only advanced users know what to enter. Still for these advanced users it is needed and therefore in the collapsed section
  • Both fields nevertheless are added to the legacy form as well if AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=True is set
  • The DAG documentation is now always expanded in the UI allowing to show instructions to the users.
  • Update screenshot in the docs to new layout

How to test?

  • Launch the UI and and trigger the DAG example_params_ui_tutorial and check the form
  • Launch webserver with ENV AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=True and trigger the DAG example_python_operatorwith config
  • Check the Github old/new screenshow if you want to have a "sneak preview".

UI Before:
image

UI After:
image

DAG Options when un-folded lower section:
image

closes: #34726

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Oct 30, 2023
@jscheffl jscheffl added this to the Airflow 2.8.0 milestone Oct 30, 2023
@jscheffl jscheffl added the type:improvement Changelog: Improvements label Oct 30, 2023
@jscheffl jscheffl changed the title Feature/hide logical date and run id in trigger Hide logical date and run id in trigger UI form Oct 30, 2023
@jscheffl jscheffl mentioned this pull request Oct 30, 2023
Merged
@potiuk
Copy link
Member

potiuk commented Oct 31, 2023

I like it. No good knowledge to comment on the code, but the ideas here are good.

eladkal
eladkal approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jscheffl jscheffl merged commit 62bdf11 into apache:main Nov 8, 2023
46 checks passed
@hterik
Copy link
Contributor

hterik commented Nov 9, 2023

Nice. Thanks @jscheffl 👍

@potiuk
Copy link
Member

potiuk commented Nov 9, 2023

Congraulations on your first (!?) merged PR as committer @jscheffl :D

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
@jscheffl @romsharon98
Hide logical date and run id in trigger UI form (apache#35284)
c825f41 
* Move Run ID and Logical Date into hidden section, layout fixes
* Make DAG docs display per default in trigger DAG UI
* Update UI Screenshot in docs
* Add form elements to legacy form as well
---------

Co-authored-by: Jens Scheffler <95105677+jens-scheffler-bosch@users.noreply.github.com>
@potiuk potiuk mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 2.8.0
Development

Successfully merging this pull request may close these issues.

Hiding Run Id and Logical date from trigger DAG UI
4 participants
@jscheffl @potiuk @hterik @eladkal