Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper bound pendulum requirement to <3.0 #35336

Merged
merged 1 commit into from Nov 1, 2023

Conversation

Taragolis
Copy link
Contributor

Just in case limit pendulum to 2.x versions.

Pendulum 3 not released yet , and we have no idea when it happen, there is WIP (#34744) on make Airflow compatible with both major versions, however the is no guarantee that it happen soon and that would not require to make some additional changes when version 3 would released


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Nov 1, 2023

Good idea.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Taragolis
Copy link
Contributor Author

I'm just not sure could we also include this into the upcoming 2.7.3 ?

@potiuk
Copy link
Member

potiuk commented Nov 1, 2023

I'm just not sure could we also include this into the upcoming 2.7.3 ?

cc: @ephraimbuddy - not sure how the release process is going (I saw some green builds with release notes/constraints yesterday). But if we have time/capacity to add some more stuff to 2.7.3 I'd vote for it. I also have few more that I'd add - specifically the #35160 and #35026 that I would love to make part of 2.7.3 still - the first one should increase stability and speed of the v2-7-test builds, the second is also improving speed of local builds for users who use our Dockerfile to build their images. I am a bit on transit today - and it's a holiday in Poland, but If @ephraimbuddy is fine with it and release is not going to happen today, I am happy with cherry-picking all of those for 2.7.3. (extremely low risk of breaking anything once the build works with all those changes.).

@ephraimbuddy
Copy link
Contributor

I'm just not sure could we also include this into the upcoming 2.7.3 ?

cc: @ephraimbuddy - not sure how the release process is going (I saw some green builds with release notes/constraints yesterday). But if we have time/capacity to add some more stuff to 2.7.3 I'd vote for it. I also have few more that I'd add - specifically the #35160 and #35026 that I would love to make part of 2.7.3 still - the first one should increase stability and speed of the v2-7-test builds, the second is also improving speed of local builds for users who use our Dockerfile to build their images. I am a bit on transit today - and it's a holiday in Poland, but If @ephraimbuddy is fine with it and release is not going to happen today, I am happy with cherry-picking all of those for 2.7.3. (extremely low risk of breaking anything once the build works with all those changes.).

You can cherry-pick it. The PR is green but it's not approved yet. I will also mark this for 2.7.3

@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.3 milestone Nov 1, 2023
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 1, 2023
@ephraimbuddy ephraimbuddy merged commit 4903b11 into apache:main Nov 1, 2023
71 checks passed
@Taragolis Taragolis deleted the limit-pendulum branch November 1, 2023 13:14
ephraimbuddy pushed a commit that referenced this pull request Nov 1, 2023
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants