Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe-to-evict annotation is not set when using KubernetesExecutor #37351

Closed
2 tasks done
csp33 opened this issue Feb 12, 2024 · 0 comments · Fixed by #37352
Closed
2 tasks done

safe-to-evict annotation is not set when using KubernetesExecutor #37351

csp33 opened this issue Feb 12, 2024 · 0 comments · Fixed by #37352
Labels
area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug

Comments

@csp33
Copy link
Contributor

csp33 commented Feb 12, 2024

Official Helm Chart version

1.11.0 (latest released)

Apache Airflow version

2.8.0

Kubernetes Version

1.29

Helm Chart configuration

executor: KubernetesExecutor
workers:
  safeToEvict: false

Docker Image customizations

No response

What happened

When running Airflow with KubernetesExecutor, the workers.safeToEvict configuration is not being used, as this field is only read in the workers deployment (used by CeleryExecutor).

What you think should happen instead

No response

How to reproduce

  1. Deploy Airflow using Kubernetes Executor. Set workers.safeToEvict: false in the chart
  2. Run a DAG
  3. Check worker pods annotations and see that the safe-to-evict one is missing

Anything else

Related PR: #35130

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@csp33 csp33 added area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Feb 12, 2024
@nathadfield nathadfield removed the needs-triage label for new issues that we didn't triage yet label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants