Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in fundamentals doc #37440

Merged
merged 2 commits into from Feb 15, 2024
Merged

Fix a bug in fundamentals doc #37440

merged 2 commits into from Feb 15, 2024

Conversation

Chitti-g-k
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Feb 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Chitti-g-k
Copy link
Contributor Author

I think it's a typo.

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@hussein-awala hussein-awala changed the title Update fundamentals.rst Fix a bug in fundamentals doc Feb 15, 2024
@hussein-awala hussein-awala merged commit 86f4775 into apache:main Feb 15, 2024
55 checks passed
Copy link

boring-cyborg bot commented Feb 15, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Feb 19, 2024
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.2 milestone Feb 19, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 20, 2024
* Update fundamentals.rst

* Update docs/apache-airflow/tutorial/fundamentals.rst

Co-authored-by: Wei Lee <weilee.rx@gmail.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
(cherry picked from commit 86f4775)
ephraimbuddy pushed a commit that referenced this pull request Feb 20, 2024
* Update fundamentals.rst

* Update docs/apache-airflow/tutorial/fundamentals.rst

Co-authored-by: Wei Lee <weilee.rx@gmail.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
(cherry picked from commit 86f4775)
sunank200 pushed a commit to astronomer/airflow that referenced this pull request Feb 21, 2024
* Update fundamentals.rst

* Update docs/apache-airflow/tutorial/fundamentals.rst

Co-authored-by: Wei Lee <weilee.rx@gmail.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
* Update fundamentals.rst

* Update docs/apache-airflow/tutorial/fundamentals.rst

Co-authored-by: Wei Lee <weilee.rx@gmail.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
(cherry picked from commit 86f4775)
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
* Update fundamentals.rst

* Update docs/apache-airflow/tutorial/fundamentals.rst

Co-authored-by: Wei Lee <weilee.rx@gmail.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants