fix(main): fix ImportError on examples dags #37571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
eladkal
reviewed
Feb 20, 2024
Taragolis
reviewed
Feb 21, 2024
|
Just one static check to fix |
xionams
force-pushed
the
fix_virtualenv_dependency
branch
from
e26972c
to
b8a66c2
Compare
eladkal
reviewed
Feb 23, 2024
|
i submitted fixes for the static checks. It should pass now |
potiuk
approved these changes
Feb 23, 2024
eladkal
approved these changes
Feb 23, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
* fix(main): fix ImportError on examples dags * thanks @eladkal * @Taragolis thanks for the review, you absoultly right. bad styling, overthinking. * Fix static check failure * Update tests/system/README.md * Update dev/PROJECT_GUIDELINES.md --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 6, 2024
* fix(main): fix ImportError on examples dags * thanks @eladkal * @Taragolis thanks for the review, you absoultly right. bad styling, overthinking. * Fix static check failure * Update tests/system/README.md * Update dev/PROJECT_GUIDELINES.md --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> (cherry picked from commit e0fc803)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 6, 2024
* fix(main): fix ImportError on examples dags * thanks @eladkal * @Taragolis thanks for the review, you absoultly right. bad styling, overthinking. * Fix static check failure * Update tests/system/README.md * Update dev/PROJECT_GUIDELINES.md --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> (cherry picked from commit e0fc803)
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* fix(main): fix ImportError on examples dags * thanks @eladkal * @Taragolis thanks for the review, you absoultly right. bad styling, overthinking. * Fix static check failure * Update tests/system/README.md * Update dev/PROJECT_GUIDELINES.md --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request is related to: apache/airflow-site#945
closes: apache/airflow-site#945
the solution of "skipped" on the dag-loading when the virtualenv is not installed
is wrap the dag loading with try-except and return None either
using this logic will guarantee the ImportError exception will not stored in the DB
and not thrown on the homepage as an error.
so if virtualenv is not installed the examples are not loaded and the exception will not thrown
tested on Ubuntu WSL2