Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better log context name than pod_manager.py for KubernetesPodOperator runtime #37843

Closed
1 of 2 tasks
ketozhang opened this issue Mar 2, 2024 · 1 comment
Closed
1 of 2 tasks
Labels
invalid kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet

Comments

@ketozhang
Copy link
Contributor

Description

KPO's runtime stderr and stdout is printed to the logger pod_manager.py module.

Use case/motivation

The context "KubernetesPodOperator" would be more clear.

Is there a reason the logs must strictly be the module file?

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ketozhang ketozhang added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Mar 2, 2024
@potiuk
Copy link
Member

potiuk commented Mar 2, 2024

Yes. This is the default convention for all loggers in Python and this is the default (and it allows to debug things more easily if you look at the source code). If you wish to change it - in Airflow 2.8+ you have the possibility to change logger name to whatever name you want: #34964

@potiuk potiuk closed this as completed Mar 2, 2024
@potiuk potiuk added the invalid label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

No branches or pull requests

2 participants