Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the UI color for ExternalSensor tasks #38845

Closed
1 of 2 tasks
Timelessprod opened this issue Apr 8, 2024 · 2 comments · Fixed by #38969
Closed
1 of 2 tasks

Change the UI color for ExternalSensor tasks #38845

Timelessprod opened this issue Apr 8, 2024 · 2 comments · Fixed by #38969
Assignees
Labels
area:core area:core-operators Operators, Sensors and hooks within Core Airflow good first issue kind:task A task that needs to be completed as part of a larger issue
Milestone

Comments

@Timelessprod
Copy link

Description

With the recent update of the graph display in DAGs, there's a visibility issue regarding external task sensors. Indeed those tasks have a #19647e tile color while the status & operator name are displayed in --chakra-colors-gray-500 (aka #718096) on top of it, which makes the text unreadable. You can see a screenshot below:

Current situation

I can submit a PR for it if needed but I'm unsure if there's a chart regarding which color to give to what type of operator etc. so please tell me. My idea would be to use same tint but lighter color like #4db7db which is more readable (see below) but not perfect for accessibility:

Suggested new color

Use case/motivation

The current color makes monitoring and debugging very annoying as it's unreadable. It is also a big issue regarding accessibility as color-blind people may not be able to guess the status name by the status color. As an argument, it was red flagged by Chrome Lighthouse when I ran a test on the webpage.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Timelessprod Timelessprod added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Apr 8, 2024
Copy link

boring-cyborg bot commented Apr 8, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@potiuk potiuk added this to the Airflow 2.9.1 milestone Apr 8, 2024
@potiuk potiuk removed the needs-triage label for new issues that we didn't triage yet label Apr 8, 2024
@idantepper
Copy link
Contributor

Hi, I would like to take this issue

@eladkal eladkal added good first issue kind:task A task that needs to be completed as part of a larger issue area:core-operators Operators, Sensors and hooks within Core Airflow area:core and removed kind:feature Feature Requests labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core area:core-operators Operators, Sensors and hooks within Core Airflow good first issue kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants