Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing conf as a filter field in dag_run browsing #39137

Open
1 of 2 tasks
raphaelauv opened this issue Apr 19, 2024 · 2 comments
Open
1 of 2 tasks

missing conf as a filter field in dag_run browsing #39137

raphaelauv opened this issue Apr 19, 2024 · 2 comments
Labels
area:core area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@raphaelauv
Copy link
Contributor

raphaelauv commented Apr 19, 2024

Apache Airflow version

2.9.0

What happened?

I can't use conf as a filter field to search a dag_run in the webserver

Screenshot from 2024-04-19 16-43-51

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@raphaelauv raphaelauv added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Apr 19, 2024
@jscheffl
Copy link
Contributor

I also was missing this option many many times. But you need to know that confis not a scalar database field but a serialized object. You can not "easily" set a filter criteria in the database engine and leverage an index to filter.

Filtering on a conf would be very heavy as actually besides filtering on other fields, all rows must be loaded and de-serialized for filtering. On a large DAG run table this could be a performance breaker and multiple such queries can be a DoS on the system.

@jscheffl jscheffl added kind:feature Feature Requests area:UI Related to UI/UX. For Frontend Developers. and removed kind:bug This is a clearly a bug labels Apr 19, 2024
@raphaelauv
Copy link
Contributor Author

Okay , but we can already order by conf and on less than 10 000 dag_runs it render almost instantly. So maybe a disclaimer on the front in the case of using a filter on this field would be a good tradeoff

@nathadfield nathadfield removed the needs-triage label for new issues that we didn't triage yet label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Development

No branches or pull requests

3 participants