Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opensearch hook passes auth even if login and password are blank #39979

Open
2 tasks done
pdebelak opened this issue May 31, 2024 · 0 comments · May be fixed by #39982
Open
2 tasks done

Opensearch hook passes auth even if login and password are blank #39979

pdebelak opened this issue May 31, 2024 · 0 comments · May be fixed by #39982

Comments

@pdebelak
Copy link
Contributor

Apache Airflow version

2.9.1

If "Other Airflow 2 version" selected, which one?

No response

What happened?

When leaving the login and password values blank, the opensearch hook passes empty strings to the http_auth parameter of opensearch which ends up generating an Authorization header with a mostly empty base64 encoded value.

What you think should happen instead?

If no login or password are passed, no http_auth argument should be provided. The elasticsearch provider works in this way.

How to reproduce

Don't set a login or password on an opensearch hook connection and try to use it to connect.

Operating System

Debian GNU/Linux 11 (bullseye)

Versions of Apache Airflow Providers

apache-airflow-providers-opensearch==1.1.2

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@pdebelak pdebelak added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels May 31, 2024
@eladkal eladkal added area:providers good first issue provider:opensearch and removed area:core needs-triage label for new issues that we didn't triage yet labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants