Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning operator to DAG via bitwise composition does not pickup default args #7996

Closed
dimberman opened this issue Mar 30, 2020 · 2 comments
Labels
kind:bug This is a clearly a bug

Comments

@dimberman
Copy link
Contributor

Ticket was created 17/Feb/17 02:58

Description

This is only the case when the operator does not specify dag=dag and is not initialized within a DAG's context manager (due to https://github.com/apache/incubator-airflow/blob/fb0c5775cda4f84c07d8d5c0e6277fc387c172e6/airflow/utils/decorators.py#L50)

Example:

default_args = {
'owner': 'airflow',
'start_date': datetime(2017, 2, 1)
}
dag = DAG('my_dag', default_args=default_args)
dummy = DummyOperator(task_id='dummy')

dag >> dummy

This will raise a Task is missing the start_date parameter. I think this should probably be allowed because I assume the purpose of supporting dag >> op was to allow delayed assignment of an operator to a DAG.

I believe to fix this, on assignment, we would need to go back and go through dag.default_args to see if any of those attrs weren't explicitly set on task...not the cleanest.

Use case / motivation

Related Issues

Moved here from https://issues.apache.org/jira/browse/AIRFLOW-883

@mik-laj mik-laj added the kind:bug This is a clearly a bug label Mar 30, 2020
@mik-laj
Copy link
Member

mik-laj commented Mar 30, 2020

@ashb Haven't you ever fixed it?

@ashb
Copy link
Member

ashb commented Mar 30, 2020

@mik-laj I had most of a solution in #5598, the question was if we want to support it at all or drop bitshifting dags in 2.0. I think that was what we decided on instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants