Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setproctitle is flaky to install and can be problematic in some environments #8079

Closed
jdavidheiser opened this issue Apr 2, 2020 · 3 comments
Labels
kind:bug This is a clearly a bug

Comments

@jdavidheiser
Copy link

Apache Airflow version: 1.10.4

Kubernetes version (if you are using kubernetes) (use kubectl version): N/A

Environment: Mac OS / Linux

  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): Mac OS 10.15.4
  • Kernel (e.g. uname -a): darwin
  • Install tools: pip/homebrew
  • Others:
    What happened:
    I am running into issues with the installation of the python library setproctitle in environments we use to run unit tests.

What you expected to happen:
Airflow to be runnable across multiple platforms and environments with minimal tweaking

From some Google results, this package seems to be especially flaky on install, often getting messed up by things like cached wheels.

This seems to be used sparingly in Airflow, and I am wondering if it adds enough utility to be worth including a package that is flaky to install, and which is not very cross platform. From the setprocutils docs:

The procedure is hardly portable across different systems. PostgreSQL provides a good multi-platform implementation: this module is a Python wrapper around PostgreSQL code.

How to reproduce it:
This would be hard to repro outside of our specific testing environment, because it is an issue of caching Python packages.

However, I have a suggested fix: remove the dependence on setproctitle. This does not seem necessary, especially as Airflow migrates toward a distributed computing environment where named containers and pods are more useful than named processes.

Anything else we need to know:

@jdavidheiser jdavidheiser added the kind:bug This is a clearly a bug label Apr 2, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 2, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@mik-laj
Copy link
Member

mik-laj commented Apr 3, 2020

Airflow uses many processes that run in one container. The clear name of the process is very useful. What alternative solution do you suggest instead of deleting it? Every problem has many solutions and death is not a solution. It's an escape. We will manage together and we will definitely get out of this situation. We do not have to take such radical steps.

@ashb
Copy link
Member

ashb commented Apr 7, 2020

Closing this in favour of #8172 as it contains more information (i.e. it contains the actual error message.)

@ashb ashb closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

3 participants