Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Endpoint - Extra Links #8140

Closed
mik-laj opened this issue Apr 4, 2020 · 4 comments · Fixed by #9475
Closed

API Endpoint - Extra Links #8140

mik-laj opened this issue Apr 4, 2020 · 4 comments · Fixed by #9475
Assignees
@mik-laj @michalslowikowski00
Labels
area:API Airflow's REST/HTTP API good first issue kind:feature Feature Requests
Projects
AIP-32: Airflow REST API

Comments

@mik-laj
Copy link
Member

mik-laj commented Apr 4, 2020

Description

We need endpoints that allow you to read extra links.

GET /dags/{dag_id}/taskInstances/{task_id}/{execution_date}/links

More details about API Endpoints:
#8118

Use case / motivation

N/A

Related Issues

N/A
@mik-laj mik-laj added kind:feature Feature Requests area:API Airflow's REST/HTTP API labels Apr 4, 2020
@mik-laj mik-laj added this to To do in AIP-32: Airflow REST API via automation Apr 4, 2020
@mik-laj mik-laj mentioned this issue Apr 4, 2020
Closed
@mik-laj mik-laj changed the title API Enddpoint - Links API Endpoint - Extra Links Apr 4, 2020
@mik-laj mik-laj mentioned this issue Jun 2, 2020
Closed
@mik-laj
Copy link
Member Author

mik-laj commented Jun 4, 2020

@michalslowikowski00 Would you like to work on it?

You should start with this file:
https://github.com/apache/airflow/blob/master/airflow/api_connexion/endpoints/extra_link_endpoint.py
These files are also related:

airflow/airflow/www/views.py

Line 2015 in d6b954d

def extra_links(self):

airflow/airflow/www/views.py

Lines 1496 to 1497 in d6b954d

if task.extra_links:
node['extra_links'] = task.extra_links

airflow/airflow/www/views.py

Line 1600 in d6b954d

'extra_links': t.extra_links,

@michalslowikowski00
Copy link
Contributor

Great :)

@mik-laj mik-laj moved this from TODO - Priority tasks - Non-assigned to TODO - Priority tasks - Assigned in AIP-32: Airflow REST API Jun 4, 2020
@mik-laj
Copy link
Member Author

mik-laj commented Jun 14, 2020 •
edited

@michalslowikowski00 How do you do? I wonder if you need help. If so, please contact me.

@michalslowikowski00
Copy link
Contributor

@michalslowikowski00 How do you do? I wonder if you need help. If so, please contact me.

Thx Kamil, I am fine. I will ask for help, definitely. I haven't start working on it yet

@mik-laj mik-laj mentioned this issue Jun 22, 2020
Merged
6 tasks
@mik-laj mik-laj moved this from TODO - Assigned to In progress - Have PR in AIP-32: Airflow REST API Jun 22, 2020
@mik-laj mik-laj self-assigned this Jun 22, 2020
AIP-32: Airflow REST API automation moved this from In progress - Have PR to Done Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mik-laj mik-laj

@michalslowikowski00 michalslowikowski00

Labels
area:API Airflow's REST/HTTP API good first issue kind:feature Feature Requests
Projects
No open projects
AIP-32: Airflow REST API
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add extra links endpoint PolideaInternal/airflow
2 participants
@mik-laj @michalslowikowski00