Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQLTo operators to use OdbcHook instead of MsSqlHook #8458

Closed
RosterIn opened this issue Apr 19, 2020 · 5 comments
Closed

MSSQLTo operators to use OdbcHook instead of MsSqlHook #8458

RosterIn opened this issue Apr 19, 2020 · 5 comments
Labels
kind:bug This is a clearly a bug

Comments

@RosterIn
Copy link
Contributor

What happened:
#6850 introduced OdbcHook and deprecated MsSqlHook
due to the deprecation of pymssql package.

As a result operators that are relaying on types from the pymssql package like:
MSSQLToGCSOperator, MsSqlToHiveTransfer will not be functional.

What you expected to happen:

MsSQLTO* operators needs to be changed to work with OdbcHook
see discussion on #6850

@RosterIn RosterIn added the kind:bug This is a clearly a bug label Apr 19, 2020
@dinigo
Copy link
Contributor

dinigo commented Sep 16, 2020

This issue is giving us some trouble too. I was about to fill a new issue when I found this old one

pymssql is being discontinued. And it's been for some time now.
Some operators conflict with this, since there's no support for pymssql in python3.8. So it is impossible to use any pymssql based operators and hooks in the python3.8 build.

Can we migrate this to the pyodbc library to manage MSSQL connections?

pymssql/pymssql#668

@juarezr
Copy link

juarezr commented Sep 18, 2020

Good news!

pymssql is not being discontinued anymore.
@termim just released a new version compatible with python3.8.

Now it's possible to deploy Airflow supporting MSSQL with python3.8.

I don't know if it's worth trying to replace pymssql by pyodbc anymore. Anyone knows what's better for the airflow case?

@dinigo
Copy link
Contributor

dinigo commented Sep 21, 2020

Great! I see we still have the deprecation warning running. @potiuk do you think it can be removed now that the library pymssql is back to stay?

/home/airflow/.local/lib/python3.8/site-packages/airflow/providers/google/cloud/transfers/mssql_to_gcs.py:25: DeprecationWarning: This module is deprecated due to the discontinuation of the pymssql project.

@RosterIn
Copy link
Contributor Author

RosterIn commented Oct 8, 2020

Interesting not sure what happens next that more for the project guys to decide. Maybe something should go on the mailing list?

@ashb
Copy link
Member

ashb commented Oct 20, 2020

Closed by #11537 -- I don't know enough about pyodbc, if someone is more familiar with it, feel free to comment/re-open this.

@ashb ashb closed this as completed Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

4 participants