Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect automatically the lack of reference to the guide in the operator descriptions #8894

Closed
mik-laj opened this issue May 17, 2020 · 4 comments
Assignees
Labels

Comments

@mik-laj
Copy link
Member

mik-laj commented May 17, 2020

Hello,

We have a lot of guides that are fantastic.
https://airflow.readthedocs.io/en/latest/howto/operator/index.html
https://airflow.readthedocs.io/en/latest/howto/operator/gcp/index.html
However, not every person may be aware that they exist. In order to promote them, we add a reference in the class description to the guide.
Screenshot 2020-05-17 at 20 07 41
Finding operators that have a guide is simple and can be based on the text pattern search.

find . -type f -name '*.rst' | xargs cat  | grep '.. _howto/operator:' | sort

In the next step we should find the operator and check the class description for reference to the guide

>>> from airflow.operators import python
>>> ':ref:`howto/operator:PythonOperator`' in python.PythonOperator.__doc__

This test should be added to the codebase::

@mik-laj mik-laj added the kind:feature Feature Requests label May 17, 2020
@mik-laj mik-laj changed the title Detect automatically the lack of reference to the guide in the operator description Detect automatically the lack of reference to the guide in the operator descriptions May 17, 2020
@ivan-afonichkin
Copy link
Contributor

Hello @mik-laj 👋

I would love to start contributing to airflow. So, would you mind assigning this issue to me?

@mik-laj
Copy link
Member Author

mik-laj commented Jun 11, 2020

Hello @ivan-afonichkin

Fantastic. I am very happy that we have a lot of new contributors. If you have any questions, ask.

A lot of health in this difficult time,
Kamil

@ivan-afonichkin
Copy link
Contributor

Hello @mik-laj, I created PR to tackle this issue using the first approach you suggested (make it directly through docs/build without importing any modules). Would you mind checking and leave some comments on PR? Thanks in advance.

#9290

@mik-laj
Copy link
Member Author

mik-laj commented Jun 14, 2020

@ivan-afonichkin I will try to look at it on Monday. I am very happy that this has been achieved. I did not think that so many problems could be detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants