Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specify s3 object ACL args for remote logging #8917

Open
kuhnhu opened this issue May 20, 2020 · 3 comments
Open

Support specify s3 object ACL args for remote logging #8917

kuhnhu opened this issue May 20, 2020 · 3 comments
Labels
area:logging kind:feature Feature Requests provider:amazon-aws AWS/Amazon - related issues

Comments

@kuhnhu
Copy link

kuhnhu commented May 20, 2020

Description
Support specify s3 object ACL args for remote logging, like 'bucket-owner-full-control'

Use case / motivation
We are deploying an airflow server in the client's AWS server, using EC2 instance role(cross account) send logging to our S3 bucket. We want to specify ACL arg "bucket-owner-full-control" to grant owner permission on logs.

Related Issues

@kuhnhu kuhnhu added the kind:feature Feature Requests label May 20, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 20, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@eladkal eladkal added area:logging provider:amazon-aws AWS/Amazon - related issues labels Nov 21, 2020
@RNHTTR
Copy link
Collaborator

RNHTTR commented Sep 4, 2023

I suspect this is already possible given S3Hook has the acl_policy parameter for many of its methods.

@RNHTTR RNHTTR closed this as completed Sep 4, 2023
@Taragolis
Copy link
Contributor

Taragolis commented Sep 4, 2023

I suspect this is already possible given S3Hook has the acl_policy parameter for many of its methods.

Yep parameter in hook exists but remote logging still do not have configurations options and implementations for that ¯\_(ツ)_/¯

update: Since Airflow 2.7 we have an options for create documented configurations for providers, might be this is a good time to move all provider specific remote logging options to the providers, and keep only remote-logging and remote-base-log-folder and maybe some other in [logging]. @eladkal @potiuk WDYT?

@o-nikolas maybe also could interested because this particular one affected Amazon Provider.

@Taragolis Taragolis reopened this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logging kind:feature Feature Requests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

No branches or pull requests

4 participants